Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update sphinx version and eliminate all warnings #105

Merged
merged 1 commit into from
Jun 11, 2019
Merged

update sphinx version and eliminate all warnings #105

merged 1 commit into from
Jun 11, 2019

Conversation

cguardia
Copy link
Contributor

@cguardia cguardia commented Jun 6, 2019

Since I'm taking so long with the document changes, I decided to split some of them into separate PRs. This reactivates warnings as errors, fixes all of them, and upgrades sphinx version.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 6, 2019
@cguardia cguardia requested a review from chrisrossi June 6, 2019 08:01
Copy link
Contributor

@chrisrossi chrisrossi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@cguardia cguardia merged commit 443e47c into googleapis:master Jun 11, 2019
chrisrossi pushed a commit that referenced this pull request Jun 12, 2019
Fixes docs build error introduced by #103 and exposed by #105.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants