Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Structured Properties #102

Merged
merged 2 commits into from
Jun 4, 2019

Conversation

chrisrossi
Copy link
Contributor

Fixes #101.

@chrisrossi chrisrossi requested a review from cguardia June 4, 2019 15:16
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 4, 2019
@@ -3362,29 +3373,29 @@ class StructuredProperty(Property):
The values of the sub-entity are indexed and can be queried.
"""

_modelclass = None
_model_class = None
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In different places, it was spelled _modelclass, _model_class, and _kls. I picked one.

Copy link
Contributor

@cguardia cguardia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@chrisrossi chrisrossi merged commit d3805d3 into googleapis:master Jun 4, 2019
@chrisrossi chrisrossi deleted the bug-structured-property branch June 4, 2019 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to save entity with a StructuredProperty
3 participants