fix: remove unnecessary detect_resource calls from CloudLoggingHandler #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xs
daniel-sanche
changed the title
simonz130
approved these changes
Feb 7, 2022
product-auto-label
bot
added
size: s
daniel-sanche
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #475
Previously, CLoudLoggingHandler would always call
detect_resource, even when a resource is passed in. This was because the handler class wasn't sending the resource to the Transport class, so it would create a new logger that would have to re-detect the resource before usage (even though the resource field will be set by handlers in this case).This PR fixes the issue by adding an optional
resourceargument to the transport classes, and making CloudLoggingHandler populate the field.This PR also adds a timeout to detect_resource to prevent similar issues in the future.