fix: add empty slots to CommonChecksum #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ariebovenberg
force-pushed
the
fix-slots
branch
from
f58461c to
b0ca95d
Compare
parthea
added
kokoro:force-run
parthea
changed the title
parthea
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$ slotscheck -m google_crc32c -v ERROR: 'google_crc32c.cext:Checksum' has slots but superclass does not.Because
CommonChecksumdoesn't have slots, the slots onChecksumare less effective. The fix was easy: adding empty slots toCommonChecksum