Skip to content
This repository has been archived by the owner on Dec 31, 2023. It is now read-only.

chore: update templated files #67

Merged
merged 1 commit into from
Jul 21, 2021
Merged

chore: update templated files #67

merged 1 commit into from
Jul 21, 2021

Conversation

yoshi-automation
Copy link
Contributor

@yoshi-automation yoshi-automation commented Jun 17, 2021

This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/9ae5ffde-098d-43fa-9bf1-5a37f69ff67d/targets

  • To automatically regenerate this PR, check this box. (May take up to 24 hours.)

@yoshi-automation yoshi-automation requested a review from a team as a code owner June 17, 2021 05:24
@product-auto-label product-auto-label bot added the api: compute Issues related to the googleapis/python-compute API. label Jun 17, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 17, 2021
@parthea
Copy link
Contributor

parthea commented Jun 17, 2021

Hey @m-strzelczyk ,

Autosynth is backing out the changes that you made in CONTRIBUTING.rst because it's an autogenerated file. The template lives here. Your update looks helpful for all repos, so I've proposed that we update the templated CONTRIBUTING.rst here. PRs are welcome in googleapis/synthtool!

@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 17, 2021
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#55 modified the autogenerated CONTRIBUTING.rst file. The section on Samples and code snippets should be added to the templated CONTRIBUTING.rst file here. I've opened a bug to track this work item.

@parthea
Copy link
Contributor

parthea commented Jul 15, 2021

Hi @m-strzelczyk, Please can you take a look?

@m-strzelczyk
Copy link
Contributor

#55 modified the autogenerated CONTRIBUTING.rst file. The section on Samples and code snippets should be added to the templated CONTRIBUTING.rst file here. I've opened a bug to track this work item.

I have merged that change and regenerated the PR, it should not remove that part from CONTRIBUTING.rst once it's done. I'll check back soon to see if this worked.

@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jul 21, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 21, 2021
        autosynth cannot find the source of changes triggered by earlier changes in this
        repository, or by version upgrades to tools such as linters.
@parthea parthea changed the title [CHANGE ME] Re-generated to pick up changes from self. chore: update templated files Jul 21, 2021
@parthea parthea merged commit 6ceab56 into master Jul 21, 2021
@parthea parthea deleted the autosynth-self branch July 21, 2021 14:56
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 22, 2021
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [x] Ensure the tests and linter pass
- [x] Code coverage does not decrease (if any source code was changed)
- [x] Appropriate docs were updated (if necessary)

Making sure that synthtool won't revert the `gcloud_project_env` setting for sample tests like it did in #67
m-strzelczyk added a commit to GoogleCloudPlatform/python-docs-samples that referenced this pull request Nov 9, 2022
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [x] Ensure the tests and linter pass
- [x] Code coverage does not decrease (if any source code was changed)
- [x] Appropriate docs were updated (if necessary)

Making sure that synthtool won't revert the `gcloud_project_env` setting for sample tests like it did in googleapis/python-compute#67
dandhlee pushed a commit to GoogleCloudPlatform/python-docs-samples that referenced this pull request Nov 16, 2022
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [x] Ensure the tests and linter pass
- [x] Code coverage does not decrease (if any source code was changed)
- [x] Appropriate docs were updated (if necessary)

Making sure that synthtool won't revert the `gcloud_project_env` setting for sample tests like it did in googleapis/python-compute#67
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Oct 21, 2023
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [x] Ensure the tests and linter pass
- [x] Code coverage does not decrease (if any source code was changed)
- [x] Appropriate docs were updated (if necessary)

Making sure that synthtool won't revert the `gcloud_project_env` setting for sample tests like it did in googleapis/python-compute#67
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: compute Issues related to the googleapis/python-compute API. cla: yes This human has signed the Contributor License Agreement. context: none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants