Skip to content
This repository has been archived by the owner on Dec 31, 2023. It is now read-only.

docs(README): Improving readme with some demos and more info #394

Merged
merged 9 commits into from
Feb 23, 2023

Conversation

m-strzelczyk
Copy link
Contributor

Related to a request sent by one of our users. They note that GO library has a much better README with some actual info on how to use the library. That's why I decided to improve ours a little too.

@m-strzelczyk m-strzelczyk requested review from a team as code owners February 10, 2023 15:39
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: compute Issues related to the googleapis/python-compute API. labels Feb 10, 2023
Copy link
Member

@rsamborski rsamborski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple nits from my side. Otherwise LGTM.

README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@vchudnov-g vchudnov-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please do remove a cruft sentence fragment left over from a previous revision (see comment)

README.rst Outdated Show resolved Hide resolved
@m-strzelczyk m-strzelczyk added the automerge Merge the pull request once unit tests and other checks pass. label Feb 23, 2023
@m-strzelczyk m-strzelczyk merged commit 7db9a9d into main Feb 23, 2023
@m-strzelczyk m-strzelczyk deleted the readme-update branch February 23, 2023 14:32
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: compute Issues related to the googleapis/python-compute API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants