This repository has been archived by the owner on Dec 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 26
docs(README): Improving readme with some demos and more info #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
Pull request size is medium.
api: compute
Issues related to the googleapis/python-compute API.
labels
Feb 10, 2023
rsamborski
approved these changes
Feb 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple nits from my side. Otherwise LGTM.
savijatv
reviewed
Feb 14, 2023
Co-authored-by: Remigiusz Samborski <[email protected]>
kweinmeister
approved these changes
Feb 16, 2023
vchudnov-g
reviewed
Feb 16, 2023
Co-authored-by: Victor Chudnovsky <[email protected]>
vchudnov-g
approved these changes
Feb 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please do remove a cruft sentence fragment left over from a previous revision (see comment)
m-strzelczyk
added
the
automerge
Merge the pull request once unit tests and other checks pass.
label
Feb 23, 2023
gcf-merge-on-green
bot
removed
the
automerge
Merge the pull request once unit tests and other checks pass.
label
Feb 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
api: compute
Issues related to the googleapis/python-compute API.
size: m
Pull request size is medium.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to a request sent by one of our users. They note that GO library has a much better README with some actual info on how to use the library. That's why I decided to improve ours a little too.