Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bigtable KNN notebook example #1022

Closed
wants to merge 1 commit into from

Conversation

cpcgoogle
Copy link

Add Bigtable KNN notebook example

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Below not in scope since this is just a sample.

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

Add Bigtable KNN notebook example
@cpcgoogle cpcgoogle requested review from a team as code owners September 9, 2024 19:06
Copy link

google-cla bot commented Sep 9, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

conventional-commit-lint-gcf bot commented Sep 9, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Sep 9, 2024
@product-auto-label product-auto-label bot added api: bigtable Issues related to the googleapis/python-bigtable API. samples Issues that are directly related to samples. labels Sep 9, 2024
@daniel-sanche
Copy link
Contributor

Sorry, we don't typically accept external samples

@daniel-sanche
Copy link
Contributor

after discussing this offline, I believe we landed on having this live in a different repo. But let me know if you want to discuss it further

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/python-bigtable API. samples Issues that are directly related to samples. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants