Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: remove google.cloud.bigquery_v2 code #855

Merged
merged 34 commits into from
Sep 27, 2021
Merged

chore!: remove google.cloud.bigquery_v2 code #855

merged 34 commits into from
Sep 27, 2021

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Aug 6, 2021 •
edited
Loading

Closes #814.

The first preview. Still need to address Model types, disable code generation, BigQuery ML classes...

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 6, 2021
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Aug 6, 2021
@plamut plamut force-pushed the iss-814 branch 4 times, most recently from 386a8bf to bc48efc Compare August 13, 2021 12:56
@plamut plamut force-pushed the iss-814 branch 3 times, most recently from 04562dd to 363eef5 Compare August 20, 2021 09:56
@plamut plamut marked this pull request as ready for review August 20, 2021 14:43
@plamut plamut requested a review from a team August 20, 2021 14:43
@plamut plamut requested review from a team as code owners August 20, 2021 14:43
@plamut
Copy link
Contributor Author

plamut commented Aug 20, 2021

This is now ready for review.

It's probably easier to review commit-by-commit, as I made the effort to keep commits mostly self-contained and independent from each other.

@plamut plamut requested a review from tswast August 20, 2021 14:45
kurtisvg
kurtisvg approved these changes Aug 20, 2021
View reviewed changes
Copy link
Contributor

@kurtisvg kurtisvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for /samples.

tswast
tswast reviewed Sep 17, 2021
View reviewed changes
samples/tests/conftest.py
@@ -125,8 +124,8 @@ def routine_id(client, dataset_id):
routine.arguments = [
bigquery.RoutineArgument(
name="x",
data_type=bigquery_v2.types.StandardSqlDataType(
type_kind=bigquery_v2.types.StandardSqlDataType.TypeKind.INT64
data_type=bigquery.StandardSqlDataType(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make sure we mention these changes to Standard SQL types and enums in the migration guide. #960

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely

@plamut plamut added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 20, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 20, 2021
@plamut
Remove validation logic from StandardSqlDataType
1b29ac2 
Client-side validation logic can drift away from the server's, thus
we let the backend perform all validation of submitted request data.
@plamut
Refactor SQL models to use shared state
adcaa03 
Modifying a sub-type should be automatically reflected on the parent
type referencing that subtype.
@plamut
Copy link
Contributor Author

plamut commented Sep 23, 2021

@tswast Pushed the implementation changes early for preview, but there are now only a few coverage misses left, thus this is close to done.

tswast
tswast reviewed Sep 23, 2021
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once coverage is there, with some small nits re: setup.py and owlbot.

docs/conf.py Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@plamut plamut requested a review from tswast September 24, 2021 08:35
@plamut plamut mentioned this pull request Sep 27, 2021
Closed
tswast
tswast approved these changes Sep 27, 2021
View reviewed changes
google/cloud/bigquery/model.py Show resolved Hide resolved
@tswast
Copy link
Contributor

tswast commented Sep 27, 2021

Thanks!

@plamut plamut added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 27, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 27, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit a7842b6 into googleapis:v3 Sep 27, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 27, 2021
@plamut plamut deleted the iss-814 branch September 28, 2021 14:49
@plamut plamut mentioned this pull request Oct 1, 2021
Closed
6 tasks
@tswast tswast mentioned this pull request Aug 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurtisvg kurtisvg kurtisvg approved these changes

@tswast tswast tswast approved these changes

@stephaniewang526 stephaniewang526 Awaiting requested review from stephaniewang526

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@plamut @tswast @kurtisvg @yoshi-kokoro