Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support parameterized NUMERIC, BIGNUMERIC, STRING, and BYTES types #673

Merged
merged 16 commits into from
May 21, 2021
Merged

feat: Support parameterized NUMERIC, BIGNUMERIC, STRING, and BYTES types #673

merged 16 commits into from
May 21, 2021

Commits on May 19, 2021

  1. parse parameterized schema info

    @jimfulton
    jimfulton committed May 19, 2021
    Configuration menu
    Copy the full SHA
    6bb6947 View commit details
    Browse the repository at this point in the history

  2. Fixed SchemaField repr/key

    @jimfulton
    jimfulton committed May 19, 2021
    Configuration menu
    Copy the full SHA
    f046fed View commit details
    Browse the repository at this point in the history

Commits on May 20, 2021

  1. Fix code duplication between _parse_schema_resource and from_api_repr 

    Move new parameterized-type code from _parse_schema_resource to from_api_repr
and implement _parse_schema_resource in terms of from_api_repr.
    @jimfulton
    jimfulton committed May 20, 2021
    Configuration menu
    Copy the full SHA
    d8199f0 View commit details
    Browse the repository at this point in the history

  2. empty schemas are lists now, just like non-empty schemas.

    @jimfulton
    jimfulton committed May 20, 2021
    Configuration menu
    Copy the full SHA
    8273afe View commit details
    Browse the repository at this point in the history

  3. changed new parameterized-type tests to use from_api_repr 

    Because that's more direct and it uncovered duplicate code.
    @jimfulton
    jimfulton committed May 20, 2021
    Configuration menu
    Copy the full SHA
    acc6f46 View commit details
    Browse the repository at this point in the history

  4. paramaterized the from_api_repr tests and added to_api_repr tests

    @jimfulton
    jimfulton committed May 20, 2021
    Configuration menu
    Copy the full SHA
    c01bc1a View commit details
    Browse the repository at this point in the history

  5. Test BYTES and _key (repr) too.

    @jimfulton
    jimfulton committed May 20, 2021
    Configuration menu
    Copy the full SHA
    2ab558c View commit details
    Browse the repository at this point in the history

  6. Added a round-trip parameterized types schema tests

    @jimfulton
    jimfulton committed May 20, 2021
    Configuration menu
    Copy the full SHA
    2d021ae View commit details
    Browse the repository at this point in the history

  7. handle BYTES in _key/repr

    @jimfulton
    jimfulton committed May 20, 2021
    Configuration menu
    Copy the full SHA
    4a1e4b7 View commit details
    Browse the repository at this point in the history

  8. blacken

    @jimfulton
    jimfulton committed May 20, 2021
    Configuration menu
    Copy the full SHA
    c4056b0 View commit details
    Browse the repository at this point in the history

  9. Move _get_int close to use

    @jimfulton
    jimfulton committed May 20, 2021
    Configuration menu
    Copy the full SHA
    a238036 View commit details
    Browse the repository at this point in the history

  10. Updated documentation.

    @jimfulton
    jimfulton committed May 20, 2021
    Configuration menu
    Copy the full SHA
    554696b View commit details
    Browse the repository at this point in the history

  11. Oops, forgot BIGNUMERIC

    @jimfulton
    jimfulton committed May 20, 2021
    Configuration menu
    Copy the full SHA
    9f5cbd5 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2021

  1. Improve argument doc and better argument name to __get_int

    @jimfulton
    jimfulton committed May 21, 2021
    Configuration menu
    Copy the full SHA
    32226e1 View commit details
    Browse the repository at this point in the history

  2. doom tables before creating them.

    @jimfulton
    jimfulton committed May 21, 2021
    Configuration menu
    Copy the full SHA
    01b714b View commit details
    Browse the repository at this point in the history

  3. Use max_length in the Python for the REST api maxLength

    @jimfulton
    jimfulton committed May 21, 2021
    Configuration menu
    Copy the full SHA
    cac957b View commit details
    Browse the repository at this point in the history