-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add opentelemetry tracing #215
Merged
Merged
Changes from all commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
b13ad47
testing first trace export
aravinsiva cacea7c
instrumention client.py
aravinsiva 63e9581
instrumenting job.py and adding documentation
aravinsiva 719ed83
reconfiguring imports
aravinsiva 72f22b6
quick cleanup of unused variable
aravinsiva ff8171f
adding more attributes in module and limiting complexity of instrumen…
aravinsiva 456b445
adding tests, nox and correct attribute additions in client & job
aravinsiva f4aba6d
adding tests, nox and correct attribute additions in client & job (le…
aravinsiva e223657
linting
aravinsiva 78b8298
reformatting noxfile.[y
aravinsiva 88b1a57
Merge branch 'master' into opentelemetry-tracing
aravinsiva e0895c9
Merge branch 'master' into opentelemetry-tracing
aravinsiva 95a35ad
addressing suggested changes
aravinsiva 3bf4574
Merge branch 'opentelemetry-tracing' of https://github.com/aravinsiva…
aravinsiva 4dbb692
adding suggested changes
aravinsiva 406f61a
removing print statements
aravinsiva c2b9add
setting same version across all OT [ackages and other reccommended ch…
aravinsiva d425909
suggested changes
aravinsiva 64ec5fd
fixing packages issue in nox and updating documentation
aravinsiva 73230dc
fixing module install issue
aravinsiva ae04fc6
restructuring design for testing adding first layer of tests (some st…
aravinsiva ac56488
adding reamining client tests and all job tests
aravinsiva d4de926
fixing linting issues
aravinsiva 2d8aeb3
Merge branch 'master' into opentelemetry-tracing
tswast cd8e303
fixing trace not defined issue
aravinsiva d8c601d
fixing lint issues
aravinsiva 2bcd106
fixing documentation issues and python2 testing issue
aravinsiva f1de589
linting and fixing coverage issues
aravinsiva 72a77d1
Merge branch 'master' into opentelemetry-tracing
tswast 0c7b354
adding suggested changes
aravinsiva 51045f1
Merge branch 'opentelemetry-tracing' of https://github.com/aravinsiva…
aravinsiva ec96f5c
linting
aravinsiva 35afadf
Merge branch 'master' into opentelemetry-tracing
aravinsiva 5a32ad4
adding Shawn's suggested changes
aravinsiva 1d7155c
Merge branch 'opentelemetry-tracing' of https://github.com/aravinsiva…
aravinsiva 54c133a
fixing _default_span_attribute_bug
aravinsiva 3aff14d
reverting uneccesxsary changes
aravinsiva 59477ff
adding more tests for all job_ref parameters
aravinsiva 0d15998
removing dependecny, ordering imports and other changes
aravinsiva d997175
addressing Shawn concerns
aravinsiva 61b5b85
adding test and suggested changes
aravinsiva 4d1dec1
adding opentelemetry to setup.py and other suggested changes
aravinsiva 7704975
adding reasoning for not adding to [all]
aravinsiva 839cd92
linting
aravinsiva dd1e246
adding Tim suggested changes
aravinsiva File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a runnable / tested code snippet somewhere this can be linked from? I'm worried that the code sample may get out-of-date / break.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently looking into it.