Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: adjust assertions about pyarrow column values #192

Merged
merged 1 commit into from
Jul 25, 2020
Merged

test: adjust assertions about pyarrow column values #192

merged 1 commit into from
Jul 25, 2020

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Jul 25, 2020 •
edited
Loading

Fixes #193. 🦕

This PR adjusts assertions that seem to have been broken by the most recent pyarrow release. I also tried running the same unit test locally with pyarrow pinned to 0.4.1 (the minimum supported version as per setup.py), and they also passed.

PR checklist

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 25, 2020
@plamut plamut marked this pull request as ready for review July 25, 2020 13:27
@plamut plamut requested a review from shollyman July 25, 2020 13:27
@plamut plamut mentioned this pull request Jul 25, 2020
Closed
@plamut plamut added the release blocking Required feature/issue must be fixed prior to next release. label Jul 25, 2020
@plamut plamut mentioned this pull request Jul 25, 2020
Merged
@shollyman shollyman merged commit e5fecce into googleapis:master Jul 25, 2020
@plamut plamut deleted the fix-tests branch July 28, 2020 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. release blocking Required feature/issue must be fixed prior to next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some pyarrow assertions are broken in unit tests
2 participants
@plamut @shollyman