feat: add support for map target type in Parquet options #1919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The map target type creates a schema without the added key_value repeated field.
product-auto-label
bot
added
the
api: bigquery
|
Thank you @sclmn for adding the new fields for us! We usually require 100% test coverage. Could you please also add unit tests for the new properties, similar to unit tests here? We also require the first commit and PR title to follow conventional commits. Could you follow the instruction in the link to update your PR? If you need any help with these, feel free to let us know :) |
sclmn
changed the title
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
|
I updated the PR. PTAL. |
Linchin
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Linchin
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Linchin
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Linchin
approved these changes
May 21, 2024
Linchin
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
This was referenced Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The map target type creates a schema without the added key_value repeated field.