-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add fields
parameter to set_iam_policy
for consistency with update methods
#1872
Conversation
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
def test_create_iam_policy(table_id: str): | ||
your_table_id = table_id | ||
|
||
# [START bigquery_create_iam_policy] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -1485,33 +1484,6 @@ def test_copy_table(self): | |||
got_rows = self._fetch_single_page(dest_table) | |||
self.assertTrue(len(got_rows) > 0) | |||
|
|||
def test_get_set_iam_policy(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is now redundant with a code sample which serves the same purpose with regards to testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Also:
get_iam_policy
andset_iam_policy
get_iam_policy
andset_iam_policy
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1871 🦕