Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade mypy to 1.6.1 #1705

Merged
merged 2 commits into from
Oct 27, 2023
Merged

chore: upgrade mypy to 1.6.1 #1705

merged 2 commits into from
Oct 27, 2023

Conversation

Linchin
Copy link
Contributor

@Linchin Linchin commented Oct 27, 2023 •
edited
Loading

Upgrades mypy version to fix presubmit error.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1704 🦕

@Linchin Linchin added the dependencies Pull requests that update a dependency file label Oct 27, 2023
@Linchin Linchin requested review from a team as code owners October 27, 2023 19:25
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Oct 27, 2023
@Linchin Linchin enabled auto-merge (squash) October 27, 2023 19:52
@Linchin Linchin requested a review from a team as a code owner October 27, 2023 21:48
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Oct 27, 2023
@Linchin Linchin changed the title chore: upgrade mypy chore: upgrade mypy to 1.6.1 Oct 27, 2023
@Linchin Linchin mentioned this pull request Oct 27, 2023
Merged
@Linchin Linchin merged commit dfe1886 into googleapis:main Oct 27, 2023
17 checks passed
@Linchin Linchin deleted the mypy-upgrade branch October 30, 2023 23:37
@Linchin Linchin mentioned this pull request Oct 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@jainsahab jainsahab Awaiting requested review from jainsahab jainsahab is a code owner automatically assigned from googleapis/api-bigquery

@m-strzelczyk m-strzelczyk Awaiting requested review from m-strzelczyk m-strzelczyk is a code owner automatically assigned from googleapis/python-samples-owners

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. dependencies Pull requests that update a dependency file size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mypy test is failing
2 participants
@Linchin @tswast