-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Revise update_table_expiration sample #1457
Conversation
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! But let's update docs/snippets.py
with a comment that we should delete the duplicate sample there once we update cloud.google.com.
@thejaredchapman I think we might want to rebase this just so we can fixup the CLA check. Would love to see the commit for #1516 as part of this PR instead of as a second PR, too. |
Manually applied the edit This didn't work, ha — someone will need to click the "request exception" link in the CLA checker log. |
494f9b7
to
deff4ad
Compare
I've squashed all commits and re-pushed. I believe that should resolve the CLA issue. |
New version of this sample added in #1457 and migrated to in the docs in internal change 570781706.
…#1673) New version of this sample added in #1457 and migrated to in the docs in internal change 570781706. Co-authored-by: Lingqing Gan <[email protected]>
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Towards #790 🦕