Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return 403 when VPC-SC violation happens #1131

Merged
merged 2 commits into from
Feb 16, 2022

Conversation

Erroration2022
Copy link
Contributor

@Erroration2022 Erroration2022 commented Feb 4, 2022

This is fixing the issue where VPC-SC violation is not returning 403. Error message map does not recognize VPCSC policy violation error and will default to return an internal server error.

This is fixing the issue where VPC-SC violation is not returning 403. Error message map does not recognize VPCSC policy violation error and will default to return an internal server error.
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Feb 4, 2022
@Erroration2022 Erroration2022 marked this pull request as ready for review February 4, 2022 17:46
@Erroration2022 Erroration2022 requested a review from a team February 4, 2022 17:46
@Erroration2022 Erroration2022 requested a review from a team as a code owner February 4, 2022 17:46
@shollyman shollyman requested a review from tswast February 5, 2022 22:35
@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2022
@tswast
Copy link
Contributor

tswast commented Feb 8, 2022

Merging blocked by googleapis/google-resumable-media-python#297

@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 16, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 16, 2022
@tswast tswast merged commit f5daa9b into googleapis:main Feb 16, 2022
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
This is fixing the issue where VPC-SC violation is not returning 403. Error message map does not recognize VPCSC policy violation error and will default to return an internal server error.

Co-authored-by: Tim Swast <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants