chore: sync v3 with main branch #1088

tswast · 2021-12-15T18:31:04Z

"do not merge" label is just a reminder to use a merge commit

* feat: allow cell magic body to be a $variable * Fix missing indefinitive article in error msg * Adjust test assertion to error message change * Refactor logic for extracting query variable * Explicitly warn about missing query variable name * Thest the query "variable" is not identifier case

* feat: promote `to_arrow_iterable` to public method * use correct version number * Update google/cloud/bigquery/table.py Co-authored-by: Tim Swast <[email protected]>

* fix: apply timeout to all resumable upload requests * Fix stub in test case * Improve timeout type and other type annotations * Annnotate return type of _do_resumable_upload()

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

…taFrame (#1078) Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Towards #1076 🦕 (edit: moved to googleapis/python-db-dtypes-pandas#45 )

* revoke dataset access setup * basic template for sample * sample + test * revoke dataset access sample * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/master/packages/owl-bot/README.md * docs: add sample for revoking dataset access - update year and string formatting * docs: add sample for revoking dataset access - move to snippets and change parameter pattern for readibility * moving update_dataset to /snippets and adjusting imports on both revoke_access and update_access * Update samples/snippets/revoke_dataset_access.py removed nested START/END tags Co-authored-by: Tim Swast <[email protected]> * Update samples/snippets/revoke_dataset_access.py update readability in API request Co-authored-by: Tim Swast <[email protected]> * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/master/packages/owl-bot/README.md * updated test * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/master/packages/owl-bot/README.md * change after running test * resolving linting failure, rewriting test * removed relative import errors * remove relative mport from update_dataset_access * adding fixture to conftest.py * updated sample * updating sample to match new update_access sample * fixing region tags * consolidated tests into one file for both methods * updating test to full_dataset format * updated revoke sample * updating test * refactored sample * Update samples/snippets/conftest.py * Update samples/snippets/revoke_dataset_access.py Co-authored-by: Tim Swast <[email protected]> * Update samples/snippets/update_dataset_access.py Co-authored-by: Tim Swast <[email protected]> * Update samples/snippets/revoke_dataset_access.py Co-authored-by: Tim Swast <[email protected]> * Update samples/snippets/revoke_dataset_access.py Co-authored-by: Tim Swast <[email protected]> * refactoring entry * added comment for entry access * Update samples/snippets/README.rst Co-authored-by: Tim Swast <[email protected]> * Update samples/snippets/dataset_access_test.py Co-authored-by: Tim Swast <[email protected]> * Update samples/snippets/dataset_access_test.py Co-authored-by: Tim Swast <[email protected]> * added develper TODO in sample * add comments to samples Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Tim Swast <[email protected]> Co-authored-by: Peter Lamut <[email protected]> Co-authored-by: Anthonios Partheniou <[email protected]> Co-authored-by: meredithslota <[email protected]>

* feat: support authorized dataset entity * cleanup * add test and cache the resource from from_api_repr in a _properties value * lint * update samples to use enums * update to_api_repr and add tests * refactor

* chore(deps): update all dependencies * exclude new geopandas from python 3.6 Co-authored-by: Tim Swast <[email protected]>

tswast · 2021-12-15T18:45:32Z

tests/unit/test_table.py

@@ -2205,6 +2205,25 @@ def test_to_arrow_iterable(self):
            [[{"name": "Bepples Phlyntstone", "age": 0}, {"name": "Dino", "age": 4}]],
        )

+    @mock.patch("google.cloud.bigquery.table.pyarrow", new=None)
+    def test_to_arrow_iterable_error_if_pyarrow_is_none(self):


Oops. I think we can delete this now that pyarrow is a required dependency

tswast · 2021-12-15T18:48:11Z

Note: the diff is a bit smaller than expected because #1081 pulled some changes in from main already

shollyman

LGTM, with the caveat that I have no real context on what's in/out of scope for the merge as I've not been following the v3 branch closely.

plamut · 2021-12-16T08:41:32Z

LGTM, with the caveat that I have no real context on what's in/out of scope for the merge as I've not been following the v3 branch closely.

Everything from the main branch should go into v3, but of course adjusted for the changes in that branch (e.g. some dependencies not optional anymore, better type hints, etc.).

plamut

LGTM.

The failures seem transient, a bunch of 500 errors.

plamut · 2021-12-16T09:12:49Z

Hm... the copy table test still consistently fails across all test runs.

tswast · 2021-12-16T16:12:50Z

Hm... the copy table test still consistently fails across all test runs.

Seth filed internal issue 210907595 to get this fixed.

plamut and others added 11 commits November 16, 2021 22:57

cleanup: silence non-relevant system test warnings (#1068)

1b5dc5c

feat: promote RowIterator.to_arrow_iterable to public method (#1073)

21cd710

* feat: promote `to_arrow_iterable` to public method * use correct version number * Update google/cloud/bigquery/table.py Co-authored-by: Tim Swast <[email protected]>

fix: apply timeout to all resumable upload requests (#1070)

3314dfb

* fix: apply timeout to all resumable upload requests * Fix stub in test case * Improve timeout type and other type annotations * Annnotate return type of _do_resumable_upload()

chore: release 2.31.0 (#1066)

a135956

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

chore: update python-docs-samples link to main branch (#1082)

44221f4

feat: support authorized dataset entity (#1075)

c098cd0

* feat: support authorized dataset entity * cleanup * add test and cache the resource from from_api_repr in a _properties value * lint * update samples to use enums * update to_api_repr and add tests * refactor

chore(deps): update all dependencies (#1005)

4a3ab03

* chore(deps): update all dependencies * exclude new geopandas from python 3.6 Co-authored-by: Tim Swast <[email protected]>

Merge remote-tracking branch 'upstream/main' into sync-v3

2b76944

tswast requested a review from a team December 15, 2021 18:31

tswast requested review from a team as code owners December 15, 2021 18:31

tswast requested review from shollyman and leahecole December 15, 2021 18:31

product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Dec 15, 2021

tswast added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 15, 2021

chore: add type annotations for mypy

950b24e

tswast changed the base branch from main to v3 December 15, 2021 18:33

tswast commented Dec 15, 2021

View reviewed changes

chore: revert test for when pyarrow is not installed

e888c71

tswast requested a review from plamut December 15, 2021 18:46

shollyman approved these changes Dec 15, 2021

View reviewed changes

plamut approved these changes Dec 16, 2021

View reviewed changes

plamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 16, 2021

yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 16, 2021

tswast added 2 commits December 16, 2021 10:51

test: skip failing copy table tests (#1090)

dc42670

Merge remote-tracking branch 'upstream/main' into sync-v3

011f160

tswast removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 16, 2021

tswast merged commit 08a9bcc into v3 Dec 16, 2021

tswast deleted the sync-v3 branch December 16, 2021 18:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: sync v3 with main branch #1088

chore: sync v3 with main branch #1088

tswast commented Dec 15, 2021 •

edited

Loading

tswast Dec 15, 2021

tswast commented Dec 15, 2021

shollyman left a comment

plamut commented Dec 16, 2021

plamut left a comment •

edited

Loading

plamut commented Dec 16, 2021

tswast commented Dec 16, 2021

chore: sync v3 with main branch #1088

chore: sync v3 with main branch #1088

Conversation

tswast commented Dec 15, 2021 • edited Loading

tswast Dec 15, 2021

Choose a reason for hiding this comment

tswast commented Dec 15, 2021

shollyman left a comment

Choose a reason for hiding this comment

plamut commented Dec 16, 2021

plamut left a comment • edited Loading

Choose a reason for hiding this comment

plamut commented Dec 16, 2021

tswast commented Dec 16, 2021

tswast commented Dec 15, 2021 •

edited

Loading

plamut left a comment •

edited

Loading