Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DB API rowcount incorrect for executemany #659

Closed
jimfulton opened this issue May 11, 2021 · 0 comments · Fixed by #660
Closed

DB API rowcount incorrect for executemany #659

jimfulton opened this issue May 11, 2021 · 0 comments · Fixed by #660
Assignees
@jimfulton
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. dbapi priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@jimfulton
Copy link
Contributor 

(3.9) jim@ds9:~/p/g/python-bigquery$ python
>>> from google.cloud.bigquery.dbapi import connect
>>> conn = connect()
>>> cursor = conn.cursor()
>>> cursor.executemany("select %s", [[1],[2],[3]])
>>> cursor.rowcount
1
@jimfulton jimfulton self-assigned this May 11, 2021
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label May 11, 2021
@jimfulton jimfulton mentioned this issue May 11, 2021
Merged
4 tasks
jimfulton added a commit to googleapis/python-bigquery-sqlalchemy that referenced this issue May 11, 2021
@jimfulton
Got RowCountTest passing
6793760 
- Provide primary key values in override. sigh.
- Skip sane_multi_rowcount tests because googleapis/python-bigquery#659
@plamut plamut added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jimfulton jimfulton

Labels
api: bigquery Issues related to the googleapis/python-bigquery API. dbapi priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: executemany rowcount only reflected the last execution googleapis/python-bigquery
2 participants
@jimfulton @plamut