-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: test on Python 3.9 #99
Conversation
autosynth cannot find the source of changes triggered by earlier changes in this repository, or by version upgrades to tools such as linters.
* docs(python): update intersphinx for grpc and auth * use https for python intersphinx Co-authored-by: Tim Swast <[email protected]> Source-Author: Bu Sun Kim <[email protected]> Source-Date: Wed Nov 18 14:37:25 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: 9a7d9fbb7045c34c9d3d22c1ff766eeae51f04c9 Source-Link: googleapis/synthtool@9a7d9fb
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
Missing some wheels. |
Might be able to run these now that 3.9 wheels (linux-only) are published https://issues.apache.org/jira/browse/ARROW-10224 |
I guess PyPI doesn't have 3.9 wheels for Arrow yet. It's only in the nightly location (until pyarrow 3.0 planned for this, I believe) apache/arrow#8386 (comment) |
from .helpers import SCALAR_COLUMNS, SCALAR_COLUMN_NAMES, SCALAR_BLOCKS | ||
|
||
|
||
pyarrow = pytest.importorskip("pyarrow") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only new logic. Everything else is just moving from test_reader_v1.py
@plamut I'd appreciate a Python sanity check on this before merging. I split out the tests that depend on |
@@ -75,7 +75,10 @@ def default(session): | |||
session.install( | |||
"mock", "pytest", "pytest-cov", | |||
) | |||
session.install("-e", ".[fastavro,pandas,pyarrow]") | |||
extras = "fastavro,pandas,pyarrow" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know synthtool
will just revert this change, but I figure we can manually keep this in until pyarrow 3.0 is out.
@tswast Sorry for missing this, this PR is so last year (pun intended) and I was recently added to several other groups, resulting in hundreds of GitHub notifications per day, making it easy to overlook stuff. I also temporarily turned off most of the notifications until I fine-tune them, as there a still a couple of repositories I do want to watch. Update: Glanced over the PR, looks fine. We can live with the non-persistent changes to the noxfile for awhile, but if it gets too annoying while waiting for pyarrow 3.0.0, we can still bake it into |
This PR was generated using Autosynth. 🌈
Synth log will be available here:
https://source.cloud.google.com/results/invocations/6f0f288a-a1e8-4b2d-a85f-00b1c6150185/targets
Source-Link: googleapis/synthtool@9a7d9fb