Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Deprecate format specific row_count field in Read API #424

Merged
merged 3 commits into from
Apr 1, 2022
+6 −2
Merged

fix: Deprecate format specific row_count field in Read API #424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
68dc309
feat: Deprecate format specific `row_count` field in Read API
gcf-owl-bot[bot] Mar 31, 2022
75b969a
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Mar 31, 2022
cc90dac
Merge branch 'main' into owl-bot-copy
parthea Apr 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion google/cloud/bigquery_storage_v1/types/arrow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,9 @@ class ArrowRecordBatch(proto.Message):
serialized_record_batch (bytes):
IPC-serialized Arrow RecordBatch.
row_count (int):
The count of rows in ``serialized_record_batch``.
[Deprecated] The count of rows in
``serialized_record_batch``. Please use the
format-independent ReadRowsResponse.row_count instead.
"""

serialized_record_batch = proto.Field(
Expand Down
4 changes: 3 additions & 1 deletion google/cloud/bigquery_storage_v1/types/avro.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,9 @@ class AvroRows(proto.Message):
serialized_binary_rows (bytes):
Binary serialized rows in a block.
row_count (int):
The count of rows in the returning block.
[Deprecated] The count of rows in the returning block.
Please use the format-independent ReadRowsResponse.row_count
instead.
"""

serialized_binary_rows = proto.Field(
Expand Down