Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add custom sync repo settings #412

Merged
merged 3 commits into from
Feb 15, 2022
Merged

chore: add custom sync repo settings #412

merged 3 commits into from
Feb 15, 2022

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Feb 9, 2022

No description provided.

@parthea parthea requested a review from a team February 9, 2022 16:55
@parthea parthea requested a review from a team as a code owner February 9, 2022 16:55
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. label Feb 9, 2022
@busunkim96
Copy link
Contributor

@parthea There seem to be samples in this repo: https://source.cloud.google.com/results/invocations/028324d7-0c47-4143-8084-7d97d28de548/targets/github%2Fpython-bigquery-sqlalchemy%2Fsamples%2Fsnippets/tests

@parthea parthea requested a review from tswast February 12, 2022 03:01
@parthea parthea mentioned this pull request Feb 12, 2022
Merged
@shollyman
Copy link

Deferring LGTM on this one to swast, I'm not sure if the sqlalchemy workflows needs any customization.

tswast
tswast requested changes Feb 14, 2022
View reviewed changes
.github/sync-repo-settings.yaml Outdated Show resolved Hide resolved
.github/sync-repo-settings.yaml Outdated Show resolved Hide resolved
@tswast
Copy link
Collaborator

tswast commented Feb 14, 2022

@parthea I think this will require an admin to merge due to missing GH Actions tests.

@tswast
Copy link
Collaborator

tswast commented Feb 15, 2022

Note: Failing Kokoro tests should be fixed by #401 , but that's blocked waiting on review and also this change to GH Actions requirements.

@tswast tswast merged commit 2ee34e2 into main Feb 15, 2022
@tswast tswast deleted the add-sync-repo-settings branch February 15, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@shollyman shollyman Awaiting requested review from shollyman

Assignees

@parthea parthea

Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@parthea @busunkim96 @shollyman @tswast