Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: alembic column rename #1098

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JacobHayes
Copy link
Contributor

@JacobHayes JacobHayes commented Jul 23, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1097 🦕

@JacobHayes JacobHayes requested review from a team as code owners July 23, 2024 01:39
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. labels Jul 23, 2024
@Linchin Linchin added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 16, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 16, 2024
@Linchin
Copy link
Contributor

Linchin commented Aug 16, 2024

Hi @JacobHayes, thanks for opening the PR and adding this feature! Looks like the system test isn't working. Could you take a look and see if you could fix it? If you need any help, feel free to let us know :)

@yirutang
Copy link

yirutang commented Oct 18, 2024

Any updates on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support alembic column renames
5 participants