Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add 'columns' as an alias for 'col_order' #701

Merged
merged 18 commits into from
Dec 6, 2023

Conversation

kiraksi
Copy link
Contributor

@kiraksi kiraksi commented Nov 21, 2023

This PR

  • adds 'columns' as an alias for 'col_order'
  • updates documentation to prefer 'columns' so that we can choose columns we want to return, and not return entire order
  • adds tests to test this functionality and to gracefully fail if a user supplies both

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #617 🦕

@kiraksi kiraksi requested review from a team as code owners November 21, 2023 03:50
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-pandas API. labels Nov 21, 2023
@kiraksi kiraksi requested a review from tswast November 21, 2023 03:51
@kiraksi kiraksi marked this pull request as draft November 21, 2023 03:51
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Nov 21, 2023
@kiraksi kiraksi added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 21, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 21, 2023
@kiraksi kiraksi added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 21, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 21, 2023
@kiraksi kiraksi marked this pull request as ready for review November 21, 2023 17:55
docs/reading.rst Outdated Show resolved Hide resolved
pandas_gbq/gbq.py Outdated Show resolved Hide resolved
@kiraksi kiraksi added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 28, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 28, 2023
pandas_gbq/gbq.py Show resolved Hide resolved
pandas_gbq/gbq.py Outdated Show resolved Hide resolved
pandas_gbq/gbq.py Show resolved Hide resolved
Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beyond the changes Tim mentioned, LGTM.
Approved pending needed resolution of Tim's comments.

@kiraksi kiraksi added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 29, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 29, 2023
pandas_gbq/gbq.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chalmerlowe chalmerlowe added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 6, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 6, 2023
@chalmerlowe chalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 6, 2023
@chalmerlowe chalmerlowe merged commit e52e8f8 into googleapis:main Dec 6, 2023
25 checks passed
@kiraksi kiraksi deleted the add-columns-alias branch January 17, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-pandas API. kokoro:force-run Add this label to force Kokoro to re-run the tests. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add "columns" as an alias for "col_order"
4 participants