Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add 'columns' as an alias for 'col_order' #298

Merged
merged 3 commits into from
Jan 4, 2024
Merged

feat: add 'columns' as an alias for 'col_order' #298

merged 3 commits into from
Jan 4, 2024

Conversation

Genesis929
Copy link
Collaborator

@Genesis929 Genesis929 commented Jan 2, 2024 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes b/318003640🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jan 2, 2024
@Genesis929 Genesis929 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 2, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 2, 2024
@Genesis929 Genesis929 marked this pull request as ready for review January 2, 2024 22:03
@Genesis929 Genesis929 requested review from a team as code owners January 2, 2024 22:03
GarrettWu
GarrettWu reviewed Jan 4, 2024
View reviewed changes
Copy link
Contributor

@GarrettWu GarrettWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I know the context why this change?

Why not just make a breaking change as we are still in preview?

@Genesis929
Copy link
Collaborator Author

Genesis929 commented Jan 4, 2024 •
edited by GarrettWu
Loading

May I know the context why this change?

Why not just make a breaking change as we are still in preview?

Forgot to include the bug link: b/318003640

This is actually a change in python-bigquery-pandas, we are just following what they did.

Their PR: googleapis/python-bigquery-pandas#701

@GarrettWu
Copy link
Contributor

May I know the context why this change?
Why not just make a breaking change as we are still in preview?

Forgot to include the bug link: b/318003640

This is actually a change in python-bigquery-pandas, we are just following what they did.

Their PR: googleapis/python-bigquery-pandas#701

SG. BTW, we shouldn't include internal links on github.

@Genesis929 Genesis929 merged commit a01b271 into main Jan 4, 2024
14 of 15 checks passed
@Genesis929 Genesis929 deleted the huanc-add-column-input branch January 4, 2024 22:41
@release-please release-please bot mentioned this pull request Jan 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GarrettWu GarrettWu GarrettWu approved these changes

@TrevorBergeron TrevorBergeron Awaiting requested review from TrevorBergeron TrevorBergeron is a code owner automatically assigned from googleapis/api-bigquery-dataframe

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Genesis929 @GarrettWu