Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: move and edit existing linear-regression tutorial snippet #991

Merged
merged 33 commits into from
Sep 24, 2024

Conversation

rey-esp
Copy link
Contributor

@rey-esp rey-esp commented Sep 16, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes b/338872698 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. samples Issues that are directly related to samples. labels Sep 16, 2024
@rey-esp
Copy link
Contributor Author

rey-esp commented Sep 16, 2024

@tswast If I remember correctly, we talked about editing the code to not filter the data, right? I commented it out for now, but I can remove/restore it if needed.

@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels Sep 18, 2024
@rey-esp
Copy link
Contributor Author

rey-esp commented Sep 18, 2024

Kokoro e2e failing test:

test_df_apply_axis_1_complex @ tests/system/large/test_remote_function.py, line:1722

@tswast tswast marked this pull request as ready for review September 18, 2024 20:02
@tswast tswast requested review from a team as code owners September 18, 2024 20:02
@tswast tswast requested a review from nicain September 18, 2024 20:02
@rey-esp rey-esp requested a review from tswast September 23, 2024 19:58
@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 24, 2024
@bigframes-bot bigframes-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 24, 2024
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@tswast
Copy link
Collaborator

tswast commented Sep 24, 2024

Let's wait for e2e to pass before merging.

In the meantime, could you post the results of pytest when running this sample localy?

@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 24, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 24, 2024
@bigframes-bot bigframes-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 24, 2024
@rey-esp
Copy link
Contributor Author

rey-esp commented Sep 24, 2024

Let's wait for e2e to pass before merging.

In the meantime, could you post the results of pytest when running this sample localy?

Really hope this is what you were expecting to see:

Screenshot 2024-09-24 1 38 42 PM

@rey-esp rey-esp merged commit 4cb62fd into main Sep 24, 2024
23 checks passed
@rey-esp rey-esp deleted the b338872698-bigframes branch September 24, 2024 19:41
@tswast
Copy link
Collaborator

tswast commented Sep 24, 2024

Really hope this is what you were expecting to see:

Awesome! Love to see those green dots. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. samples Issues that are directly related to samples. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants