Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: bigframes.options.bigquery.project and location are optional in some circumstances #548

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Mar 29, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Follow-up to launch feedback and #451
🦕

@tswast tswast requested review from a team as code owners March 29, 2024 20:33
@tswast tswast requested review from leahecole and ashleyxuu March 29, 2024 20:33
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 29, 2024
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Mar 29, 2024
@tswast tswast added the automerge Merge the pull request once unit tests and other checks pass. label Apr 3, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 90bcec5 into main Apr 3, 2024
15 of 16 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the tswast-project-and-locaton branch April 3, 2024 14:46
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 3, 2024
Genesis929 pushed a commit that referenced this pull request Apr 9, 2024
…l in some circumstances (#548)

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/python-bigquery-dataframes/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Follow-up to launch feedback and https://togithub.com/googleapis/python-bigquery-dataframes/pull/451
🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants