Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add "Supported pandas APIs" reference to the documentation #542

Merged
merged 14 commits into from
Mar 29, 2024

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Mar 28, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

🦕

@tswast tswast requested a review from ashleyxuu March 28, 2024 22:26
@tswast tswast requested review from a team as code owners March 28, 2024 22:26
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 28, 2024
@tswast
Copy link
Collaborator Author

tswast commented Mar 28, 2024

Preview from a local nox -r -s docs build:

Screenshot 2024-03-28 at 5 32 33 PM

Copy link
Contributor

@ashleyxuu ashleyxuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content looks good to me, but I'm not able to generate the page directly through nox -s docfx. Let me check with CloudRAD team to see if they have any solution.

@tswast tswast requested a review from ashleyxuu March 29, 2024 15:54
@@ -72,6 +72,8 @@
name: Series
- name: Window
uid: bigframes.core.window.Window
- name: Supported pandas APIs
href: supported_pandas_apis.html
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashleyxuu Is this the right way to do this? I can't figure out how to get the HTML file to stage.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- href: supported_pandas_apis.html
      name: Supported pandas APIs

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Mar 29, 2024
@ashleyxuu ashleyxuu added the automerge Merge the pull request once unit tests and other checks pass. label Mar 29, 2024
@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 29, 2024
@bigframes-bot bigframes-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 29, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 74c3915 into main Mar 29, 2024
15 of 16 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the docs-supported-pandas-apis branch March 29, 2024 23:28
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 29, 2024
Genesis929 pushed a commit that referenced this pull request Apr 9, 2024
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/python-bigquery-dataframes/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants