Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support ML.GENERATE_EMBEDDING in PaLM2TextEmbeddingGenerator #539

Merged
merged 3 commits into from
Mar 29, 2024
Merged

feat: support ML.GENERATE_EMBEDDING in PaLM2TextEmbeddingGenerator #539

merged 3 commits into from
Mar 29, 2024

Conversation

ashleyxuu
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal #331805797🦕

@ashleyxuu ashleyxuu requested a review from GarrettWu March 28, 2024 18:31
@ashleyxuu ashleyxuu requested review from a team as code owners March 28, 2024 18:31
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 28, 2024
@ashleyxuu ashleyxuu force-pushed the ashleyxu-migrate-embedding-syntax branch from bc8c312 to a432b9d Compare March 29, 2024 04:10
@ashleyxuu ashleyxuu merged commit 1156c1e into main Mar 29, 2024
15 of 16 checks passed
@ashleyxuu ashleyxuu deleted the ashleyxu-migrate-embedding-syntax branch March 29, 2024 17:23
@release-please release-please bot mentioned this pull request Mar 29, 2024
Merged
@tswast
Copy link
Collaborator

tswast commented Apr 1, 2024

This was a breaking change. We need to tag features that depend on preview BigQuery features as preview.

@tswast tswast mentioned this pull request Apr 1, 2024
Merged
@GarrettWu
Copy link
Contributor

This was a breaking change. We need to tag features that depend on preview BigQuery features as preview.

Unfortunately embedding is a GA feature. But we can only mark it as breaking.

Genesis929 pushed a commit that referenced this pull request Apr 9, 2024
@ashleyxuu @Genesis929
feat: support ML.GENERATE_EMBEDDING in PaLM2TextEmbeddingGenerator (
68607ad 
#539)

* feat: support ML.GENERATE_EMBEDDING in PaLM2TextEmbeddingGenerator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GarrettWu GarrettWu GarrettWu approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashleyxuu @tswast @GarrettWu