Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: rename ml model params #491

Merged
merged 5 commits into from
Mar 23, 2024
Merged

feat!: rename ml model params #491

merged 5 commits into from
Mar 23, 2024

Conversation

GarrettWu
Copy link
Contributor

@GarrettWu GarrettWu commented Mar 21, 2024

Includes following changes:

  • renaming min_rel_progress -> tol, to be consistent with sklearn
  • not allowing setting early_stop anymore, always to True
  • renaming n_parallell_trees -> n_estimators, to be consistent with sklearn
  • renaming class_weights -> class_weight, to be consistent with sklearn
  • renaming learn_rate -> learning_rate, to be consistent with sklearn
  • PCA n_components supports float value and None now, default to None

BEGIN_COMMIT_OVERRIDE
feat!: rename various ml model parameters for consistency with sklearn (#491)

feat!: rename model parameter min_rel_progress to tol
fix!: early_stop setting no longer supported, always uses True
feat!: rename model parameter n_parallell_trees to n_estimators
feat!: rename class_weights to class_weight
feat!: rename learn_rate to learning_rate
feat!: PCA n_components supports float value and None, default to None
END_COMMIT_OVERRIDE

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 21, 2024
@GarrettWu GarrettWu requested review from shobsi and ashleyxuu March 22, 2024 07:27
@GarrettWu GarrettWu marked this pull request as ready for review March 22, 2024 07:27
@GarrettWu GarrettWu requested review from a team as code owners March 22, 2024 07:27
@GarrettWu GarrettWu added the automerge Merge the pull request once unit tests and other checks pass. label Mar 23, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 65c6f47 into main Mar 23, 2024
15 of 16 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the garrettwu-breaking branch March 23, 2024 08:42
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants