fix: fix -1 offset lookups failing #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xs
shobsi
reviewed
Mar 20, 2024
tests/system/small/test_series.py
Outdated
| @@ -215,7 +215,7 @@ def test_series___getitem__(scalars_dfs, index_col, key): | |||
| def test_series___getitem___with_int_key(scalars_dfs): | |||
| col_name = "int64_too" | |||
| index_col = "string_col" | |||
| key = 2 | |||
| key = -1 | |||
There was a problem hiding this comment.
can we not parameterize this and test for both test cases and more - {-3, -2, -1, 0, 1, 2, 3}?
There was a problem hiding this comment.
added a few more test cases
product-auto-label
bot
added
size: xl
TrevorBergeron
force-pushed
the
series_indexer
branch
from
79d5ba1 to
469110a
Compare
product-auto-label
bot
added
size: s
shobsi
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕