Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (Series|DataFrame).plot #438

Merged
merged 1 commit into from
Mar 15, 2024
Merged

feat: (Series|DataFrame).plot #438

merged 1 commit into from
Mar 15, 2024

Conversation

chelsea-lin
Copy link
Contributor

Fixes internal bug: b/322178330 🦕

@chelsea-lin chelsea-lin requested a review from junyazhang March 13, 2024 19:43
@chelsea-lin chelsea-lin requested review from a team as code owners March 13, 2024 19:43
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 13, 2024
with columns 'b' and 'd'. Remaining columns that aren't specified
will be plotted in additional subplots (one per column).

.. versionadded:: 1.5.0
Copy link
Contributor

@junyazhang junyazhang Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that we are extending pandas, shall we keep this version note here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Removed!

When using a secondary_y axis, automatically mark the column
labels with "(right)" in the legend.
include_bool : bool, default is False
If True, boolean values can be plotted.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we support all these parameters?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation of existing plotting methods are converting BF DataFrames and calling pandas.DataFrame.plot(). Hence, all arguments listed at pandas.DataFrame.plot() should also support here technically. Though I didn't have chance to test all these arguments yet.

Maybe I would just comment them as Options to pass to pandas.DataFrame.plot method. for now?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you paste the staged doc link here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chelsea-lin chelsea-lin force-pushed the main_chelsealin_line branch 2 times, most recently from d792f25 to b462808 Compare March 14, 2024 05:26
Base automatically changed from main_chelsealin_line to main March 14, 2024 16:11
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_plot branch from 5ff0641 to 9cadbb0 Compare March 14, 2024 17:50
@chelsea-lin chelsea-lin requested a review from junyazhang March 14, 2024 18:03
@chelsea-lin chelsea-lin merged commit 1c3e668 into main Mar 15, 2024
15 checks passed
@chelsea-lin chelsea-lin deleted the main_chelsealin_plot branch March 15, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants