-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: (Series|DataFrame).plot #438
Conversation
with columns 'b' and 'd'. Remaining columns that aren't specified | ||
will be plotted in additional subplots (one per column). | ||
|
||
.. versionadded:: 1.5.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that we are extending pandas, shall we keep this version note here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Removed!
When using a secondary_y axis, automatically mark the column | ||
labels with "(right)" in the legend. | ||
include_bool : bool, default is False | ||
If True, boolean values can be plotted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we support all these parameters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation of existing plotting methods are converting BF DataFrames and calling pandas.DataFrame.plot()
. Hence, all arguments listed at pandas.DataFrame.plot() should also support here technically. Though I didn't have chance to test all these arguments yet.
Maybe I would just comment them as Options to pass to pandas.DataFrame.plot method.
for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you paste the staged doc link here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
d792f25
to
b462808
Compare
5ff0641
to
9cadbb0
Compare
Fixes internal bug: b/322178330 🦕