test: do GCF cleanup in both presubmit and e2e tests #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
shobsi
added
the
kokoro:force-run
bigframes-bot
removed
the
kokoro:force-run
tswast
reviewed
Mar 15, 2024
tests/system/conftest.py
Outdated
| from tests.system.utils import convert_pandas_dtypes | ||
| from tests.system.utils import ( | ||
| convert_pandas_dtypes, | ||
| delete_cloud_function, |
There was a problem hiding this comment.
Same here. Import the "utils" package/module, not the individual functions.
tests/system/conftest.py
Outdated
| @@ -21,6 +21,7 @@ | |||
| import typing | |||
| from typing import Dict, Optional | |||
|
|
|||
| from google.api_core.exceptions import NotFound, ResourceExhausted | |||
There was a problem hiding this comment.
Nit: Use import statements for packages and modules only, not for individual types, classes, or functions.
https://google.github.io/styleguide/pyguide.html#22-imports
The only exception is with the typing package.
tests/system/utils.py
Outdated
| import numpy as np | ||
| import pandas as pd | ||
| import pyarrow as pa # type: ignore | ||
| import pytest | ||
|
|
||
| from bigframes.functions.remote_function import get_remote_function_locations |
There was a problem hiding this comment.
Same here. Import packages/modules, not functions.
tswast
approved these changes
Mar 19, 2024
TrevorBergeron
pushed a commit
that referenced
this pull request
Mar 20, 2024
* test: do GCF cleanup in both presubmit and e2e tests * use functions client from session * address review comments --------- Co-authored-by: Tim Sweña (Swast) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes internal issue 328515697 🦕