fix: only do row identity based joins when joining by index

[DLT1412]

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

• Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
• Ensure the tests and linter pass
• Code coverage does not decrease (if any source code was changed)
• Appropriate docs were updated (if necessary)

Fixes #355 🦕

[conventional-commit-lint-gcf]

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

[DLT1412]

@TrevorBergeron can you take a look?

[tswast]

This would likely be a regression with regards to our SQL size. We want to simulate a join in this case. I'll take a look at join_by_row_identity_ordered and join_by_row_identity_unordered to see if there has been a regression there.

[DLT1412]

any update on this?

[tswast]

Hi @DLT1412 Sorry for the wait. I was OOO for a couple weeks to get married. I hope to look at this more deeply later this week. Thanks again for raising this issue.

[tswast]

I'm able to reproduce this issue locally with inner, outer, and left join. Will look more tomorrow.