Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: read_gbq large response issue #332

Merged
merged 3 commits into from
Jan 19, 2024
Merged

fix: read_gbq large response issue #332

merged 3 commits into from
Jan 19, 2024

Conversation

Genesis929
Copy link
Collaborator

@Genesis929 Genesis929 commented Jan 19, 2024 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #303057336 🦕

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jan 19, 2024
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Jan 19, 2024
@Genesis929 Genesis929 marked this pull request as ready for review January 19, 2024 20:08
@Genesis929 Genesis929 requested review from a team as code owners January 19, 2024 20:08
@Genesis929 Genesis929 requested a review from tswast January 19, 2024 20:08
@Genesis929 Genesis929 changed the title fix: read_gbq large size return issue fix: read_gbq large response issue Jan 19, 2024
@Genesis929 Genesis929 requested a review from GarrettWu January 19, 2024 20:11
@Genesis929 Genesis929 added the automerge Merge the pull request once unit tests and other checks pass. label Jan 19, 2024
@Genesis929 Genesis929 merged commit b8178b9 into main Jan 19, 2024
14 of 15 checks passed
@Genesis929 Genesis929 deleted the huanc-readgbq-fix branch January 19, 2024 20:53
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 19, 2024
@release-please release-please bot mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GarrettWu GarrettWu GarrettWu approved these changes

@tswast tswast Awaiting requested review from tswast tswast is a code owner automatically assigned from googleapis/api-bigquery-dataframe

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Genesis929 @GarrettWu