Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update bigframes.pandas.pandas docstrings #1247

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

docs: update bigframes.pandas.pandas docstrings #1247

wants to merge 2 commits into from
+27 −16

Conversation

arwas11
Copy link
Contributor

@arwas11 arwas11 commented Jan 2, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<296390934> 🦕

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jan 2, 2025
@arwas11 arwas11 marked this pull request as ready for review January 3, 2025 18:55
@arwas11 arwas11 requested review from a team as code owners January 3, 2025 18:55
@arwas11 arwas11 requested a review from shobsi January 3, 2025 18:55
shobsi
shobsi approved these changes Jan 4, 2025
View reviewed changes
bigframes/session/__init__.py
@@ -641,7 +641,8 @@ def read_gbq_model(self, model_name: str):
to load from the default project.

Returns:
A bigframes.ml Model, Transformer or Pipeline wrapping the model.
bigframes.ml model:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just "model" should suffice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shobsi shobsi shobsi approved these changes

Assignees

@liujiashang liujiashang

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arwas11 @shobsi @liujiashang