Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ARIMAPlus series input #1237

Merged
merged 2 commits into from
Dec 23, 2024
+4 −4
Merged

fix: ARIMAPlus series input #1237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9539f5d
fix: arima model series input.
Genesis929 Dec 20, 2024
78db385
Merge branch 'main' into arima_fix_huanc
Genesis929 Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bigframes/ml/forecasting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,15 +199,15 @@ def _fit(
Returns:
ARIMAPlus: Fitted estimator.
"""
X, y = utils.batch_convert_to_dataframe(X, y)

if X.columns.size != 1:
raise ValueError(
"Time series timestamp input X must only contain 1 column."
)
if y.columns.size != 1:
Genesis929 marked this conversation as resolved.
Show resolved Hide resolved
raise ValueError("Time series data input y must only contain 1 column.")

X, y = utils.batch_convert_to_dataframe(X, y)

self._bqml_model = self._bqml_model_factory.create_time_series_model(
X,
y,
Expand Down
4 changes: 2 additions & 2 deletions tests/system/large/ml/test_forecasting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
@pytest.fixture(scope="module")
def arima_model(time_series_df_default_index):
model = forecasting.ARIMAPlus()
X_train = time_series_df_default_index[["parsed_date"]]
X_train = time_series_df_default_index["parsed_date"]
y_train = time_series_df_default_index[["total_visits"]]
model.fit(X_train, y_train)
return model
Expand Down Expand Up @@ -114,7 +114,7 @@ def test_arima_plus_model_fit_params(time_series_df_default_index, dataset_id):
)

X_train = time_series_df_default_index[["parsed_date"]]
y_train = time_series_df_default_index[["total_visits"]]
y_train = time_series_df_default_index["total_visits"]
model.fit(X_train, y_train)

# save, load to ensure configuration was kept
Expand Down
Loading