fix: unordered mode too many labels issue. #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xs
shobsi
reviewed
Nov 12, 2024
|
|
||
| if not self.strictly_ordered: | ||
| job_config.labels["bigframes-mode"] = "unordered" | ||
|
|
||
| # Note: add_labels is global scope which may have unexpected effects | ||
| bq_io.add_labels(job_config, api_name=api_name) |
There was a problem hiding this comment.
Highly recommend adding a test using the customer's use case
product-auto-label
bot
added
size: s
shobsi
reviewed
Nov 12, 2024
| @@ -2766,22 +2766,17 @@ def test_series_case_when(scalars_dfs_maybe_ordered): | |||
| bf_series = scalars_df["int64_col"] | |||
| pd_series = scalars_pandas_df["int64_col"] | |||
|
|
|||
| # TODO(tswast): pandas case_when appears to assume True when a value is | |||
There was a problem hiding this comment.
I would keep this comment, or rather add a dedicated test that clearly conveys the intent - test_series_case_when_with_large_number_of_operations, or even test_series_large_number_of_operations, with comment that describes the labels limit
There was a problem hiding this comment.
Updated to have all cases in the original test. Keep only one test can be overall faster I think.
shobsi
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕