-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: show best practice of closing the session to cleanup resources in sample notebooks #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigquery
Issues related to the googleapis/python-bigquery-dataframes API.
label
Oct 17, 2024
…s-cleanup-default
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
product-auto-label
bot
added
size: m
Pull request size is medium.
and removed
size: xs
Pull request size is extra small.
labels
Oct 18, 2024
shobsi
changed the title
chore: clean up stale cloud functions up in default nox run
chore: Oct 18, 2024
cleanup
in default nox runs, make remote function notebooks self cleaning
shobsi
changed the title
chore:
chore: Oct 18, 2024
cleanup
in default nox runs, make remote function notebooks self cleaningcleanup
in default nox runs, self cleaning in remote function notebooks
tswast
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it! Thanks so much for helping document these best practices, Shobhit.
tswast
changed the title
chore:
docs: show best practice of closing the session to cleanup resources in sample notebooks
Oct 18, 2024
cleanup
in default nox runs, self cleaning in remote function notebooks
shobsi
added
the
automerge
Merge the pull request once unit tests and other checks pass.
label
Oct 18, 2024
gcf-merge-on-green
bot
removed
the
automerge
Merge the pull request once unit tests and other checks pass.
label
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: bigquery
Issues related to the googleapis/python-bigquery-dataframes API.
size: m
Pull request size is medium.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
docs: show best practice of closing the session to cleanup resources in sample notebooks (#1095)
test: include stale cloud functions cleanup in the default nox run (#1095)
END_COMMIT_OVERRIDE
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕