Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Make expression nodes prunable #1030

Merged
merged 5 commits into from
Oct 2, 2024
Merged

refactor: Make expression nodes prunable #1030

merged 5 commits into from
Oct 2, 2024

Conversation

TrevorBergeron
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Sep 28, 2024
@TrevorBergeron TrevorBergeron force-pushed the explicit_new_cols branch 2 times, most recently from a051511 to cb1395a Compare September 30, 2024 16:33
@TrevorBergeron TrevorBergeron changed the title refactor: Simplify join and read table nodes refactor: Make expression nodes prunable Sep 30, 2024
@TrevorBergeron TrevorBergeron marked this pull request as ready for review September 30, 2024 22:36
@TrevorBergeron TrevorBergeron requested review from a team as code owners September 30, 2024 22:36
@TrevorBergeron TrevorBergeron enabled auto-merge (squash) October 2, 2024 00:40
@TrevorBergeron TrevorBergeron merged commit 4105dba into main Oct 2, 2024
20 of 23 checks passed
@TrevorBergeron TrevorBergeron deleted the explicit_new_cols branch October 2, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chelsea-lin chelsea-lin chelsea-lin approved these changes

Assignees

@arwas11 arwas11

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TrevorBergeron @chelsea-lin @arwas11