Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sync the notebook with embedding changes #550

Merged
merged 2 commits into from
Mar 30, 2024

Conversation

ashleyxuu
Copy link
Contributor

@ashleyxuu ashleyxuu commented Mar 29, 2024

Edit: For context, the error column name was changed in #539 with the change to use ML.GENERATE_EMBEDDING instead of ML.GENERATE_TEXT_EMBEDDING

@ashleyxuu ashleyxuu requested a review from GarrettWu March 29, 2024 22:48
@ashleyxuu ashleyxuu requested review from a team as code owners March 29, 2024 22:48
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

conventional-commit-lint-gcf bot commented Mar 29, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 29, 2024
@ashleyxuu ashleyxuu changed the title fix: sync the notebook with embedding model changes fix: sync the notebook with embedding changes Mar 29, 2024
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: xs Pull request size is extra small. labels Mar 29, 2024
@ashleyxuu ashleyxuu added the automerge Merge the pull request once unit tests and other checks pass. label Mar 29, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 347f2dd into main Mar 30, 2024
15 of 16 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the ashleyxu-fix-embedding-notebook branch March 30, 2024 00:08
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 30, 2024
Genesis929 pushed a commit that referenced this pull request Apr 9, 2024
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/python-bigquery-dataframes/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants