Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: chance default connection name in getting_started.ipnyb #347

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

shanecglass
Copy link
Contributor

@shanecglass shanecglass commented Jan 24, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • [X ] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • [X ] Ensure the tests and linter pass
  • [ X] Code coverage does not decrease (if any source code was changed)
  • [X ] Appropriate docs were updated (if necessary)

Fixes #346

The existing notebook references an incorrect default connection name. This PR corrects that so that users can more easily cleanup after they use the getting started notebook

@shanecglass shanecglass requested review from a team as code owners January 24, 2024 17:19
Copy link

conventional-commit-lint-gcf bot commented Jan 24, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jan 24, 2024
@tswast tswast added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 26, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 26, 2024
@tswast tswast added the automerge Merge the pull request once unit tests and other checks pass. label Jan 26, 2024
@bigframes-bot bigframes-bot removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jan 26, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 677f014 into googleapis:main Jan 26, 2024
14 of 15 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: getting_started notebook fails to remove connection created
3 participants