Skip to content

Commit

Permalink
fix: chance default connection name in getting_started.ipnyb (#347)
Browse files Browse the repository at this point in the history
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [X ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/python-bigquery-dataframes/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [X ] Ensure the tests and linter pass
- [ X] Code coverage does not decrease (if any source code was changed)
- [X ] Appropriate docs were updated (if necessary)

Fixes #346

The existing notebook references an incorrect default connection name. This PR corrects that so that users can more easily cleanup after they use the [getting started notebook](https://togithub.com/googleapis/python-bigquery-dataframes/blob/main/notebooks/getting_started/getting_started_bq_dataframes.ipynb)
  • Loading branch information
shanecglass authored Jan 26, 2024
1 parent 0794788 commit 677f014
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -925,7 +925,7 @@
"# # Delete the BigQuery Connection\n",
"# from google.cloud import bigquery_connection_v1 as bq_connection\n",
"# client = bq_connection.ConnectionServiceClient()\n",
"# CONNECTION_ID = f\"projects/{PROJECT_ID}/locations/{REGION}/connections/bigframes-rf-conn\"\n",
"# CONNECTION_ID = f\"projects/{PROJECT_ID}/locations/{REGION}/connections/bigframes-default-connection\"\n",
"# client.delete_connection(name=CONNECTION_ID)\n",
"# print(\"Deleted connection '{}'.\".format(CONNECTION_ID))"
]
Expand Down

0 comments on commit 677f014

Please sign in to comment.