Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: resolve issue where protos are not updating #123

Merged
merged 8 commits into from
Aug 14, 2024
Merged

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Feb 10, 2024

Fixes #122 🦕

BEGIN_COMMIT_OVERRIDE
feat: Add PolicyViolation. this will only be present when access is denied due to Organization Policy fc5be6f
feat: Add the principal field to the ServiceAccountDelegationInfo ba89dac
feat: Update AuditLog proto to include all new changes in Audit Logging 40292fc
feat: Add google/cloud/audit/bigquery_audit_metadata_pb2.py
END_COMMIT_OVERRIDE

@parthea parthea requested a review from a team as a code owner February 10, 2024 19:37
@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Feb 10, 2024
@parthea
Copy link
Contributor Author

parthea commented Feb 12, 2024

Review #117 first

Copy link

@vchudnov-g vchudnov-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion and a question about copyrights. But LGTM. Thanks for taking this on!

owlbot.py Outdated Show resolved Hide resolved
google/cloud/audit/audit_log.proto Outdated Show resolved Hide resolved
@parthea parthea assigned parthea and unassigned vchudnov-g and ohmayr Aug 14, 2024
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 14, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 14, 2024
@parthea parthea enabled auto-merge (squash) August 14, 2024 17:39
@parthea parthea merged commit c6efc56 into main Aug 14, 2024
13 checks passed
@parthea parthea deleted the update-protos branch August 14, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update protos in google/cloud/audit
3 participants