Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use not instead of is False in assert #366

Merged
merged 3 commits into from
Apr 26, 2022
Merged

test: use not instead of is False in assert #366

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
173b568
test: use == instead of is when comparing equality
parthea Apr 19, 2022
488a062
use not instead of ==
parthea Apr 19, 2022
1df3444
Merge branch 'main' into parthea-patch-1
parthea Apr 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/unit/test_extended_operation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ def make_extended_operation(responses=None):
def test_constructor():
ex_op, refresh, _ = make_extended_operation()
assert ex_op._extended_operation == refresh.responses[0]
assert ex_op.cancelled() is False
assert ex_op.done() is False
assert not ex_op.cancelled()
assert not ex_op.done()
assert ex_op.name == TEST_OPERATION_NAME
assert ex_op.status == CustomOperation.StatusCode.PENDING
assert ex_op.error_code is None
Expand Down