-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added aiplatform.Model.update
method
#952
Conversation
79d31cb
to
4a4a6b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add or update an integration test to use this method:
An additional test case can be added here using the same model: https://github.com/googleapis/python-aiplatform/blob/main/tests/system/aiplatform/test_model_upload.py
It can also be added to this e2e test: https://github.com/googleapis/python-aiplatform/blob/main/tests/system/aiplatform/test_e2e_tabular.py
783b162
to
48459c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: sasha-gitg <[email protected]>
model.update
methodaiplatform.Model.update
method
Fixed bug in integration test introduced by #952
Fixed bug in integration test introduced by googleapis#952
Added ability to update
display_name
,description
andlabels
.Fixes https://b.corp.google.com/issues/213921337
TODO
Test code
Bug?
There's some weirdness going on with the eTags though. If I don't "refetch" the model from the server, I get an "etag mismatch" exception on the subsequent update.
Tracked at b/214432914