Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixed BigQuery datasets that have colon in URI #855

Merged
merged 6 commits into from
Jan 11, 2022
Merged

fix: Fixed BigQuery datasets that have colon in URI #855

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ee307ab
fix: Fixed BigQuery datasets that have colon in URI
Ark-kun Nov 19, 2021
614201a
Merge branch 'main' into fix--Fixed-BigQuery-datasets-that-have-colon…
kweinmeister Dec 7, 2021
3d60f97
Merge branch 'main' into fix--Fixed-BigQuery-datasets-that-have-colon…
sasha-gitg Jan 6, 2022
6289fa5
Fixed the fix
Ark-kun Jan 8, 2022
aeae015
Merge branch 'main' into fix--Fixed-BigQuery-datasets-that-have-colon…
ivanmkc Jan 10, 2022
9a7fd5f
Merge branch 'main' into fix--Fixed-BigQuery-datasets-that-have-colon…
ivanmkc Jan 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions google/cloud/aiplatform/datasets/column_names_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,12 @@ def _retrieve_bq_source_columns(
if bq_table_uri.startswith(prefix):
bq_table_uri = bq_table_uri[len(prefix) :]

# The colon-based "project:dataset.table" format is no longer supported:
# Invalid dataset ID "bigquery-public-data:chicago_taxi_trips".
# Dataset IDs must be alphanumeric (plus underscores and dashes) and must be at most 1024 characters long.
# Using dot-based "project.dataset.table" format instead.
bq_table_uri = bq_table_uri.replace(":", ".")

client = bigquery.Client(project=project, credentials=credentials)
table = client.get_table(bq_table_uri)
schema = table.schema
Expand Down