-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding Python 3.10 support + updating google-vizier version #1644
Conversation
It seems like I have to manually add in the changes, I'll do that now. |
6a4cdce
to
e0c2e98
Compare
Hi @nayaknishant, Please update this line to update the templated files and then add the Line 91 in dfc9578
|
Thanks @parthea. I'm now running into a 3.10 unit test issue:
|
@halio-g any insight on this error? I think it's related to the google-vizier package for Python 3.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the Vizier change
Hey @parthea, I think we're ready to support Python version 3.10 (TensorFlow now supports Python 3.10). Is there more to do for 3.10 support other than adding the extra line to
setup.py
(I'm assuming this change will automatically update the related files) or will I need to manually add toCONTRIBUTING.rst
,noxfile.py
, andowlbot.py
(according to #831)?Thanks,
Nishant