Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added the PipelineJob.from_pipeline_func method #1415

Merged
merged 17 commits into from
Jul 15, 2022
Merged

feat: Added the PipelineJob.from_pipeline_func method #1415

merged 17 commits into from
Jul 15, 2022

Commits on Jun 28, 2022

  1. feat: Added the PipelineJob.submit_from_pipeline_func method

    @Ark-kun
    Ark-kun committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    4bbe41a View commit details
    Browse the repository at this point in the history

  2. Bumped the copyright year

    @Ark-kun
    Ark-kun committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    35a9375 View commit details
    Browse the repository at this point in the history

  3. Added docstring

    @Ark-kun
    Ark-kun committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    cb2c175 View commit details
    Browse the repository at this point in the history

  4. Raising more informative exceptions when the kfp compiler module cann… 

    …ot be loaded
    @Ark-kun
    Ark-kun committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    279d7f2 View commit details
    Browse the repository at this point in the history

  5. Split the submit_from_pipeline_func into from_pipeline_func and submit

    @Ark-kun
    Ark-kun committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    9040503 View commit details
    Browse the repository at this point in the history

  6. Fixed the formatting

    @Ark-kun
    Ark-kun committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    0c25131 View commit details
    Browse the repository at this point in the history

  7. Refactored the change to only create the artifact bucket when submit … 

    …is called

It's advised to not perform any complex operations (especially making external changes) as part of constructors of factory methods.
    @Ark-kun
    Ark-kun committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    5498f42 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2022

  1. Renamed the arguments parameter to parameter_values for consistency w… 

    …ith PipelineJob

Unfortunately, the parameter_values parameter name itself was chosen inconsistently with the KFP SDK and ComponentSpec that both use the "arguments" naming.
    @Ark-kun
    Ark-kun committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    b3a99c6 View commit details
    Browse the repository at this point in the history

  2. Using the PipelineJob.from_pipeline_func method in tests

    @Ark-kun
    Ark-kun committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    c0b95e7 View commit details
    Browse the repository at this point in the history

  3. Added a PipelineJob.from_pipeline_func integration test

    @Ark-kun
    Ark-kun committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    9c1e1ac View commit details
    Browse the repository at this point in the history

  4. Added artifact bucket mock to the unit tests

    @Ark-kun
    Ark-kun committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    2f4b70e View commit details
    Browse the repository at this point in the history

  5. Fixed the PipelineJob.from_pipeline_func integration test

    @Ark-kun
    Ark-kun committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    85909e8 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2022

  1. Implemented the review feedback

    @Ark-kun
    Ark-kun committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    5cbcd8b View commit details
    Browse the repository at this point in the history

  2. Reverting the test_experiments.py changes

    @Ark-kun
    Ark-kun committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    56247e8 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into feat--Added-the-PipelineJob.submit_from_pipe… 

    …line_func-method
    @Ark-kun
    Ark-kun authored Jul 12, 2022
    Configuration menu
    Copy the full SHA
    1eb5a04 View commit details
    Browse the repository at this point in the history

  4. Fixed the tests added after this PR was created

    @Ark-kun
    Ark-kun committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    bb04e46 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2022

  1. Merge branch 'main' into feat--Added-the-PipelineJob.submit_from_pipe… 

    …line_func-method
    @sasha-gitg
    sasha-gitg authored Jul 15, 2022
    Configuration menu
    Copy the full SHA
    a7fd13f View commit details
    Browse the repository at this point in the history