Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add hierarchy and window configs to Vertex Forecasting training job #1255

Merged
merged 7 commits into from
May 27, 2022
Merged

feat: Add hierarchy and window configs to Vertex Forecasting training job #1255

merged 7 commits into from
May 27, 2022

Conversation

TheMichaelHu
Copy link
Contributor

@TheMichaelHu TheMichaelHu commented May 25, 2022 •
edited
Loading

Adds support for hierarchical forecasting and window filtering.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes b/229907889 b/228499154 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: vertex-ai Issues related to the googleapis/python-aiplatform API. labels May 25, 2022
@TheMichaelHu TheMichaelHu requested a review from ivanmkc May 25, 2022 20:38
ivanmkc
ivanmkc approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@ivanmkc ivanmkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheMichaelHu TheMichaelHu added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 26, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 26, 2022
@TheMichaelHu TheMichaelHu added the automerge Merge the pull request once unit tests and other checks pass. label May 27, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 8560fa8 into googleapis:main May 27, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 27, 2022
@release-please release-please bot mentioned this pull request May 27, 2022
Merged
@release-please release-please bot mentioned this pull request Jun 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joannejqi joannejqi joannejqi approved these changes

@ivanmkc ivanmkc ivanmkc approved these changes

Assignees

@ivanmkc ivanmkc

Labels
api: vertex-ai Issues related to the googleapis/python-aiplatform API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TheMichaelHu @ivanmkc @joannejqi @yoshi-kokoro