feat: Make matching engine API public #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanmkc
force-pushed
the
imkc--matching-engine-2
branch
2 times, most recently
from
992fdde
to
528a915
Compare
product-auto-label
bot
added
size: m
ivanmkc
commented
May 2, 2022
ivanmkc
changed the title
ivanmkc
force-pushed
the
imkc--matching-engine-2
branch
from
c402b50
to
e094de1
Compare
ivanmkc
commented
May 4, 2022
4 tasks
product-auto-label
bot
added
size: xl
sararob
added
the
do not merge
ivanmkc
force-pushed
the
imkc--matching-engine-2
branch
from
ba2a6c8
to
a652001
Compare
ivanmkc
force-pushed
the
imkc--matching-engine-2
branch
from
8fd7294
to
485934b
Compare
ivanmkc
force-pushed
the
imkc--matching-engine-2
branch
from
485934b
to
46d77bd
Compare
ivanmkc
commented
May 6, 2022
| @@ -136,7 +136,10 @@ def tear_down_resources(self, shared_state: Dict[str, Any]): | |||
| # Bring all Endpoints to the front of the list | |||
| # Ensures Models are undeployed first before we attempt deletion | |||
| shared_state["resources"].sort( | |||
| key=lambda r: 1 if isinstance(r, aiplatform.Endpoint) else 2 | |||
| key=lambda r: 1 | |||
There was a problem hiding this comment.
I had talked to Morgan before about some ideas to clean this up. This will get uglier as time passes.
ivanmkc
commented
May 6, 2022
| == _TEST_MAX_REPLICA_COUNT_UPDATED | ||
| ) | ||
|
|
||
| # TODO: Test `my_index_endpoint.match` request. This requires running this test in a VPC. |
There was a problem hiding this comment.
Still don't know how to run the whole system test "inside" the VPC network.
sasha-gitg
removed
the
do not merge
sasha-gitg
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #995
Adds system tests for APIs that require VPC network.
TODO
Dependent on https://github.com/googleapis/python-aiplatform/pull/1195/files